Support update the backup VolumeInfos by the Async ops result. #7554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7554 +/- ##
==========================================
- Coverage 61.74% 61.53% -0.21%
==========================================
Files 265 265
Lines 29257 29355 +98
==========================================
- Hits 18064 18063 -1
- Misses 9910 10004 +94
- Partials 1283 1288 +5 ☔ View full report in Codecov by Sentry. |
blackpiglet
force-pushed
the
7357_fix
branch
2 times, most recently
from
4585190 to
9f8bfd2
Compare
blackpiglet
force-pushed
the
7357_fix
branch
8 times, most recently
from
44c66ae to
7edbb9a
Compare
Lyndon-Li
reviewed
Mar 25, 2024
Lyndon-Li
reviewed
Mar 25, 2024
blackpiglet
force-pushed
the
7357_fix
branch
2 times, most recently
from
2d1ce0f to
d447b0b
Compare
1. Add PutBackupVolumeInfos method. 2. Add CompletionTimestamp in VolumeInfo. 3. Add Size in SnapshotDataMovementInfo. 4. Update CompletionTimpstmap, SnapshotHandle, RetainedSnapshot and Size in VolumeInfo on DataUpload Operation completes. Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
blackpiglet
force-pushed
the
7357_fix
branch
3 times, most recently
from
a063e0f to
44a0dfa
Compare
handleSkippedPVHasRetainPolicy According to comment, calling executePVAction aims to reset PV's claimRef, but the reset logic was moved into resetVolumeBindingInfo since release-1.4. Signed-off-by: Xun Jiang <blackpigletbruce@gmail.com>
Lyndon-Li
approved these changes
Mar 29, 2024
qiuming-best
approved these changes
Apr 1, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #7357
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.