Get resource client again after restore actions in case resource's gv is changed #6634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is changed Signed-off-by: lou <alex1988@outlook.com>
27149chen
force-pushed
the
allow-update-gv
branch
from
949a679
to
1784f63
Compare
Codecov Report
@@ Coverage Diff @@
## main #6634 +/- ##
=======================================
Coverage 60.18% 60.18%
=======================================
Files 242 242
Lines 25711 25712 +1
=======================================
+ Hits 15474 15475 +1
Misses 9156 9156
Partials 1081 1081
|
Signed-off-by: lou <alex1988@outlook.com>
ywk253100
approved these changes
Aug 14, 2023
reasonerjt
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
Get resource client again after restore actions in case resource's gv is changed.
This is an improvement of pr #6499, to support group changes. A group change usually happens in a restore plugin which is used for resource conversion: convert a resource from a not supported gv to a supported gv
Does your change fix a particular issue?
Fixes #6498
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.