Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Resource modifiers docs / site #6501

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

anshulahuja98
Copy link
Collaborator

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Docs for : #6452

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #6501 (9805f87) into main (9c8275e) will decrease coverage by 0.18%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

❗ Current head 9805f87 differs from pull request most recent head 94d3494. Consider uploading reports for the commit 94d3494 to get more accurate results

@@            Coverage Diff             @@
##             main    #6501      +/-   ##
==========================================
- Coverage   60.36%   60.18%   -0.18%     
==========================================
  Files         239      241       +2     
  Lines       25498    25617     +119     
==========================================
+ Hits        15391    15417      +26     
- Misses       9036     9130      +94     
+ Partials     1071     1070       -1     

see 5 files with indirect coverage changes

@anshulahuja98
Copy link
Collaborator Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jul 14, 2023
@anshulahuja98 anshulahuja98 changed the title [WIP] Resource modifiers docs / site Resource modifiers docs / site Jul 25, 2023
@anshulahuja98 anshulahuja98 changed the title Resource modifiers docs / site Add Resource modifiers docs / site Jul 25, 2023
@anshulahuja98 anshulahuja98 marked this pull request as ready for review July 25, 2023 09:06
Copy link
Collaborator

@sseago sseago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple minor suggestions on wording, otherwise looks good.

site/content/docs/main/restore-resource-modifiers.md Outdated Show resolved Hide resolved
site/content/docs/main/restore-resource-modifiers.md Outdated Show resolved Hide resolved
Signed-off-by: Anshul Ahuja <anshulahuja@microsoft.com>
@anshulahuja98
Copy link
Collaborator Author

A couple minor suggestions on wording, otherwise looks good.

Resolved the comments

@anshulahuja98
Copy link
Collaborator Author

@blackpiglet / @ywk253100 can you please review.

@blackpiglet blackpiglet merged commit 18586bc into vmware-tanzu:main Aug 1, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes Website non-docs changes for the website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants