Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting TTL in backup E2E test #4896

Merged
merged 1 commit into from
May 16, 2022

Conversation

danfengliu
Copy link
Contributor

@danfengliu danfengliu commented May 9, 2022

Signed-off-by: danfengl danfengl@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #4264

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@danfengliu danfengliu changed the title Add setting TTL in backup E2E test [WIP] Add setting TTL in backup E2E test May 9, 2022
@github-actions github-actions bot requested review from blackpiglet and jenting May 9, 2022 06:52
@danfengliu danfengliu changed the title [WIP] Add setting TTL in backup E2E test WIP: Add setting TTL in backup E2E test May 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2022

Codecov Report

Merging #4896 (92d1a37) into main (419f9dd) will increase coverage by 0.59%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4896      +/-   ##
==========================================
+ Coverage   41.13%   41.73%   +0.59%     
==========================================
  Files         204      204              
  Lines       18095    18164      +69     
==========================================
+ Hits         7443     7580     +137     
+ Misses      10102    10012      -90     
- Partials      550      572      +22     
Impacted Files Coverage Δ
pkg/controller/gc_controller.go 76.31% <0.00%> (-1.87%) ⬇️
pkg/restore/restore.go 65.35% <0.00%> (-1.35%) ⬇️
pkg/install/resources.go 52.55% <0.00%> (-0.25%) ⬇️
pkg/builder/restore_builder.go 0.00% <0.00%> (ø)
pkg/cmd/util/output/restore_describer.go 0.00% <0.00%> (ø)
pkg/cmd/server/server.go 7.02% <0.00%> (+0.12%) ⬆️
pkg/install/deployment.go 86.91% <0.00%> (+0.44%) ⬆️
pkg/controller/restic_repository_controller.go 52.25% <0.00%> (+52.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419f9dd...92d1a37. Read the comment docs.

@blackpiglet blackpiglet requested review from qiuming-best and removed request for jenting May 11, 2022 02:48
@danfengliu danfengliu force-pushed the add-backup-ttl-e2e-test branch from 52d24e4 to 92d1a37 Compare May 11, 2022 03:11
@danfengliu danfengliu added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label May 11, 2022
@danfengliu danfengliu force-pushed the add-backup-ttl-e2e-test branch 6 times, most recently from 626f6c8 to 0e08c7a Compare May 13, 2022 02:19
@danfengliu danfengliu requested a review from ywk253100 May 13, 2022 02:23
@danfengliu danfengliu force-pushed the add-backup-ttl-e2e-test branch from 0e08c7a to a6c0691 Compare May 13, 2022 02:25
@blackpiglet blackpiglet changed the title WIP: Add setting TTL in backup E2E test Add setting TTL in backup E2E test May 13, 2022
ywk253100
ywk253100 previously approved these changes May 13, 2022
Signed-off-by: danfengl <danfengl@vmware.com>
@danfengliu danfengliu force-pushed the add-backup-ttl-e2e-test branch from 6ce5b68 to 18621a0 Compare May 13, 2022 06:53
@blackpiglet blackpiglet merged commit 74d36e5 into vmware-tanzu:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add E2E test of backup TTL
5 participants