-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting TTL in backup E2E test #4896
Merged
blackpiglet
merged 1 commit into
vmware-tanzu:main
from
danfengliu:add-backup-ttl-e2e-test
May 16, 2022
Merged
Add setting TTL in backup E2E test #4896
blackpiglet
merged 1 commit into
vmware-tanzu:main
from
danfengliu:add-backup-ttl-e2e-test
May 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danfengliu
changed the title
Add setting TTL in backup E2E test
[WIP] Add setting TTL in backup E2E test
May 9, 2022
danfengliu
changed the title
[WIP] Add setting TTL in backup E2E test
WIP: Add setting TTL in backup E2E test
May 9, 2022
Codecov Report
@@ Coverage Diff @@
## main #4896 +/- ##
==========================================
+ Coverage 41.13% 41.73% +0.59%
==========================================
Files 204 204
Lines 18095 18164 +69
==========================================
+ Hits 7443 7580 +137
+ Misses 10102 10012 -90
- Partials 550 572 +22
Continue to review full report at Codecov.
|
danfengliu
force-pushed
the
add-backup-ttl-e2e-test
branch
from
May 11, 2022 03:11
52d24e4
to
92d1a37
Compare
danfengliu
added
the
kind/changelog-not-required
PR does not require a user changelog. Often for docs, website, or build changes
label
May 11, 2022
danfengliu
force-pushed
the
add-backup-ttl-e2e-test
branch
6 times, most recently
from
May 13, 2022 02:19
626f6c8
to
0e08c7a
Compare
danfengliu
force-pushed
the
add-backup-ttl-e2e-test
branch
from
May 13, 2022 02:25
0e08c7a
to
a6c0691
Compare
blackpiglet
changed the title
WIP: Add setting TTL in backup E2E test
Add setting TTL in backup E2E test
May 13, 2022
ywk253100
previously approved these changes
May 13, 2022
danfengliu
force-pushed
the
add-backup-ttl-e2e-test
branch
from
May 13, 2022 06:18
a6c0691
to
6ce5b68
Compare
Signed-off-by: danfengl <danfengl@vmware.com>
danfengliu
force-pushed
the
add-backup-ttl-e2e-test
branch
from
May 13, 2022 06:53
6ce5b68
to
18621a0
Compare
qiuming-best
approved these changes
May 13, 2022
blackpiglet
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
has-e2e-tests
kind/changelog-not-required
PR does not require a user changelog. Often for docs, website, or build changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: danfengl danfengl@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #4264
Please indicate you've done the following:
/kind changelog-not-required
as a comment on this pull request.site/content/docs/main
.