Keep the annotation "pv.kubernetes.io/provisioned-by" when restoring PVs #4391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywk253100
force-pushed
the
211123_anno
branch
from
5406258
to
84b451f
Compare
ywk253100
changed the title
ywk253100
changed the title
jenting
reviewed
Nov 23, 2021
changelogs/unreleased/4391-ywk253100
Outdated
| @@ -0,0 +1 @@ | |||
| Keep the annotation "pv.kubernetes.io/provisioned-by" when storing PVs | |||
There was a problem hiding this comment.
Suggested change
| Keep the annotation "pv.kubernetes.io/provisioned-by" when storing PVs | |
| Keep the annotation "pv.kubernetes.io/provisioned-by" when restoring PVs |
ywk253100
force-pushed
the
211123_anno
branch
from
84b451f
to
dcc4ca1
Compare
ywk253100
force-pushed
the
211123_anno
branch
from
dcc4ca1
to
1febea5
Compare
|
Tested on:
|
reasonerjt
previously approved these changes
Dec 21, 2021
jenting
reviewed
Dec 21, 2021
pkg/restore/restore_test.go
Outdated
| @@ -2989,15 +2989,15 @@ func Test_resetVolumeBindingInfo(t *testing.T) { | |||
| WithName("pv-1").WithAnnotations( | |||
| KubeAnnBindCompleted, | |||
| KubeAnnBoundByController, | |||
| KubeAnnDynamicallyProvisioned, | |||
There was a problem hiding this comment.
I don't know why need this change that removing the const variable and use string instead.
ywk253100
force-pushed
the
211123_anno
branch
from
1febea5
to
065a035
Compare
More details please refer to vmware-tanzu#3470 (comment) Fixes vmware-tanzu#3470 Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>
ywk253100
force-pushed
the
211123_anno
branch
from
065a035
to
648f3ac
Compare
reasonerjt
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details please refer to #3470 (comment)
Fixes #3470
Signed-off-by: Wenkai Yin(尹文开) yinw@vmware.com
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.