Use region in BSL for restic repo identifier #3857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jalaja Ganapathy <jalaja@replicated.com> Signed-off-by: Jalaja <jalaja@replicated.com>
zubron
force-pushed
the
use-region-in-bsl-for-restic-repo-identifier
branch
from
996e083 to
6316f79
Compare
Also refactor the AWS `getRepoPrefix` logic to remove use of `switch` statement. Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
Signed-off-by: Bridget McErlean <bmcerlean@vmware.com>
zubron
force-pushed
the
use-region-in-bsl-for-restic-repo-identifier
branch
from
6316f79 to
1495d61
Compare
sseago
approved these changes
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
This PR incorporates the changes made by @jala-dx in #3617. We were unable to push requested changes to that PR branch so the original commit and requested changes are included in this PR. The tests for this function have been refactored to use table-driven tests and a new test case for this fix has been added.
This change also updates the original changelog provided in that PR to match the new PR number and author.
Does your change fix a particular issue?
Fixes #3616
Please indicate you've done the following:
/kind changelog-not-required.site/content/docs/main.