Added volume snapshot test for backup/restore. #3592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsu-igeek
added
kind/release-blocker
zubron
suggested changes
Mar 16, 2021
There was a problem hiding this comment.
Thanks, @dsu-igeek! This looks good so far but there are a few cases where we're attempting to use volume snapshots but shouldn't be.
dsu-igeek
force-pushed
the
e2e-volume-snapshots-03-12-2021
branch
from
2096e9e to
a415fb5
Compare
github-actions
bot
added
the
Dependencies
dsu-igeek
added
the
kind/changelog-not-required
|
@dsu-igeek I'm starting to look at this now. You might have noticed CI is failing:
I also noticed there was no addition to the README but disregard if it's not needed. |
dsu-igeek
force-pushed
the
e2e-volume-snapshots-03-12-2021
branch
from
a415fb5 to
4da31f4
Compare
|
@carlisia The README didn't have anything to change (the use-volume-snapshots flag wasn't there before) so I'm going to leave that alone but I did add a changelog and fixed the module stuff. THanks! |
…run with Ginkgo focus "Snapshot" and restic tests with Ginkgo focus "Restic". Restic and volume snapshot tests can now be run simultaneously. Added check for kibishii app start after restore. Consolidated kibishii pod checks into waitForKibishiiPods. Added WaitForPods function to e2e/tests/common.go Snapshot tests are skipped automatically on kind clusters. Fixed issue where velero_utils InstallVeleroServer was looking for the Restic daemon set in the "velero" namespace only (was ignoring io.Namespace) Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
dsu-igeek
force-pushed
the
e2e-volume-snapshots-03-12-2021
branch
from
4da31f4 to
bee3dec
Compare
pradeep288
pushed a commit
to pradeep288/velero
that referenced
this pull request
May 4, 2021
Snapshot tests can be run with Ginkgo focus "Snapshot" and restic tests with Ginkgo focus "Restic". Restic and volume snapshot tests can now be run simultaneously. Added check for kibishii app start after restore. Consolidated kibishii pod checks into waitForKibishiiPods. Added WaitForPods function to e2e/tests/common.goSnapshot tests are skipped automatically on kind clusters. Fixed issue where velero_utils InstallVeleroServer was looking for the Restic daemon set in the "velero" namespace only (was ignoring io.Namespace) Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com> Signed-off-by: Pradeep Jigalur <pjigalur@vmware.com>
dharmab
pushed a commit
to dharmab/velero
that referenced
this pull request
May 25, 2021
Snapshot tests can be run with Ginkgo focus "Snapshot" and restic tests with Ginkgo focus "Restic". Restic and volume snapshot tests can now be run simultaneously. Added check for kibishii app start after restore. Consolidated kibishii pod checks into waitForKibishiiPods. Added WaitForPods function to e2e/tests/common.goSnapshot tests are skipped automatically on kind clusters. Fixed issue where velero_utils InstallVeleroServer was looking for the Restic daemon set in the "velero" namespace only (was ignoring io.Namespace) Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
ywk253100
pushed a commit
to ywk253100/velero
that referenced
this pull request
Jun 29, 2021
Snapshot tests can be run with Ginkgo focus "Snapshot" and restic tests with Ginkgo focus "Restic". Restic and volume snapshot tests can now be run simultaneously. Added check for kibishii app start after restore. Consolidated kibishii pod checks into waitForKibishiiPods. Added WaitForPods function to e2e/tests/common.goSnapshot tests are skipped automatically on kind clusters. Fixed issue where velero_utils InstallVeleroServer was looking for the Restic daemon set in the "velero" namespace only (was ignoring io.Namespace) Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
Snapshot tests can be run with Ginkgo focus "Snapshot" and restic tests with Ginkgo focus "Restic". Restic and volume snapshot tests can now be run simultaneously. Added check for kibishii app start after restore. Consolidated kibishii pod checks into waitForKibishiiPods. Added WaitForPods function to e2e/tests/common.goSnapshot tests are skipped automatically on kind clusters. Fixed issue where velero_utils InstallVeleroServer was looking for the Restic daemon set in the "velero" namespace only (was ignoring io.Namespace) Signed-off-by: Dave Smith-Uchida <dsmithuchida@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot tests can be run with Ginkgo focus "Snapshot" and restic tests with
Ginkgo focus "Restic". Restic and volume snapshot tests can now be run simultaneously. Added check for kibishii app start
after restore. Consolidated kibishii pod checks into waitForKibishiiPods. Added WaitForPods function to e2e/tests/common.go
Snapshot tests are skipped automatically on kind clusters
Does your change fix a particular issue?
Fixes #3233