Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve plugin release instructions #3591

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

carlisia
Copy link
Contributor

Signed-off-by: Carlisia carlisia@vmware.com

Please indicate you've done the following:

dsu-igeek
dsu-igeek previously approved these changes Apr 15, 2021
Copy link
Contributor

@dsu-igeek dsu-igeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@a-mccarthy a-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small nits

site/content/docs/main/plugin-release-instructions.md Outdated Show resolved Hide resolved
site/content/docs/main/plugin-release-instructions.md Outdated Show resolved Hide resolved
Carlisia added 3 commits April 19, 2021 13:53
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
Signed-off-by: Carlisia <carlisia@vmware.com>
@carlisia
Copy link
Contributor Author

This is ready for another review, thank you.

Copy link
Contributor

@a-mccarthy a-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jenting jenting merged commit 06c5e01 into vmware-tanzu:main Apr 21, 2021
ywk253100 pushed a commit to ywk253100/velero that referenced this pull request Jun 29, 2021
* Improve plugin release instructions
* Improve the improvement
* Fix broken links
* Add a link to e2e tests documentation

Signed-off-by: Carlisia <carlisia@vmware.com>
gyaozhou pushed a commit to gyaozhou/velero-read that referenced this pull request May 14, 2022
* Improve plugin release instructions
* Improve the improvement
* Fix broken links
* Add a link to e2e tests documentation

Signed-off-by: Carlisia <carlisia@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants