Enable automatic labeling of PRs via Actions #3431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
nrb
added
CI/CD
kind/changelog-not-required
github-actions
bot
requested review from
ashish-amarnath,
carlisia,
dsu-igeek,
jenting and
zubron
nrb
commented
Feb 8, 2021
| - uses: jpmcb/prow-github-actions@v1 | ||
| with: | ||
| # Only support /kind command for now. | ||
| # TODO: before allowing the /lgtm command, see if we can block merging if changelog labels are missing. |
There was a problem hiding this comment.
I'm wondering if we can use the /lgtm command, but make it work only if there's either a has-changelog (which should be set with the action on this PR) or changelog-not-required label on the PR.
I think this way, we could retire the confusing changelog CI check that marks a perfectly-fine PR as failing.
carlisia
previously approved these changes
Feb 8, 2021
Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
I think I'll leave it open and address that later. This PR changes a lot already, and I wanna make sure it works :) |
carlisia
approved these changes
Feb 9, 2021
zubron
approved these changes
Feb 9, 2021
dharmab
pushed a commit
to dharmab/velero
that referenced
this pull request
May 25, 2021
* Automatically label PRs based on the file paths Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Enable prow-like commands Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Require filling in the PR template Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Update contributor docs to reference PR template Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Expand checklist and ask for issue number on PRs Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Document why we're not enabling /lgtm yet Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Combine PR assignment and labeling workflow Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
ywk253100
pushed a commit
to ywk253100/velero
that referenced
this pull request
Jun 29, 2021
* Automatically label PRs based on the file paths Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Enable prow-like commands Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Require filling in the PR template Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Update contributor docs to reference PR template Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Expand checklist and ask for issue number on PRs Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Document why we're not enabling /lgtm yet Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Combine PR assignment and labeling workflow Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
gyaozhou
pushed a commit
to gyaozhou/velero-read
that referenced
this pull request
May 14, 2022
* Automatically label PRs based on the file paths Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Enable prow-like commands Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Require filling in the PR template Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Update contributor docs to reference PR template Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Expand checklist and ask for issue number on PRs Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Document why we're not enabling /lgtm yet Signed-off-by: Nolan Brubaker <brubakern@vmware.com> * Combine PR assignment and labeling workflow Signed-off-by: Nolan Brubaker <brubakern@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces 2 ways of labeling PRs:
/kindor/areacommands via the prow-github ActionIt also adds a checklist that contributors should fill out upon PR creation, and updates the code standards docs to reference it.