Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Documentation [issue-1715] #1957

Merged
merged 1 commit into from
Nov 4, 2019

Conversation

nainav
Copy link
Contributor

@nainav nainav commented Oct 12, 2019

Added Restore Documentation [issue-1715]
This PR is regarding : Clarify implications of removing restore object #1715

Closes #1715

Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @nainav! I had a couple of suggestions around wording.

Also, please remove the .dnconfig file from this PR.

Lastly, you'll need to add DCO signoff to your commit (see https://github.com/vmware-tanzu/velero/blob/master/CONTRIBUTING.md#dco-sign-off for more details) -- git commit --amend --signoff followed by git push -f should do it. If you add new commits, make sure to include the --signoff flag in your git commit command.

site/docs/master/restore-reference.md Outdated Show resolved Hide resolved
site/docs/master/restore-reference.md Outdated Show resolved Hide resolved
site/docs/master/restore-reference.md Show resolved Hide resolved
@skriss
Copy link
Contributor

skriss commented Oct 28, 2019

@nainav just checking in here to see if you were planning to work through the feedback or if you needed any more information, thanks :)

@nainav
Copy link
Contributor Author

nainav commented Oct 31, 2019

@skriss , I am planning to work on it. I will update the PR soon, Thanks for Review comments.

@nainav nainav force-pushed the nainav/restore-doc branch 2 times, most recently from dc0c69c to 72febf1 Compare November 1, 2019 06:30
@nainav
Copy link
Contributor Author

nainav commented Nov 1, 2019

Hi @skriss ,
Please find the resolved changes and I have Signed-off the PR as well.

Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nainav I added a couple more minor proofreading edits, but once those are addressed I think this is ready to merge.

site/docs/master/restore-reference.md Outdated Show resolved Hide resolved
site/docs/master/restore-reference.md Outdated Show resolved Hide resolved
site/docs/master/restore-reference.md Outdated Show resolved Hide resolved
Signed-off-by: naina verma <vnaina@cloudhealthtech.com>
@nainav nainav force-pushed the nainav/restore-doc branch from 72febf1 to 9437f6c Compare November 4, 2019 05:50
@nainav
Copy link
Contributor Author

nainav commented Nov 4, 2019

@skriss , I have resolved above review comments and pushed the changes

Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for the PR @nainav!

@skriss skriss merged commit 984e2ce into vmware-tanzu:master Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify implications of removing restore object
2 participants