-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Documentation [issue-1715] #1957
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR @nainav! I had a couple of suggestions around wording.
Also, please remove the .dnconfig
file from this PR.
Lastly, you'll need to add DCO signoff to your commit (see https://github.com/vmware-tanzu/velero/blob/master/CONTRIBUTING.md#dco-sign-off for more details) -- git commit --amend --signoff
followed by git push -f
should do it. If you add new commits, make sure to include the --signoff
flag in your git commit
command.
@nainav just checking in here to see if you were planning to work through the feedback or if you needed any more information, thanks :) |
@skriss , I am planning to work on it. I will update the PR soon, Thanks for Review comments. |
dc0c69c
to
72febf1
Compare
Hi @skriss , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nainav I added a couple more minor proofreading edits, but once those are addressed I think this is ready to merge.
Signed-off-by: naina verma <vnaina@cloudhealthtech.com>
72febf1
to
9437f6c
Compare
@skriss , I have resolved above review comments and pushed the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks again for the PR @nainav!
Added Restore Documentation [issue-1715]
This PR is regarding : Clarify implications of removing restore object #1715
Closes #1715