Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

record restic restore progress in PodVolumeRestore #1854

Merged
merged 7 commits into from
Sep 10, 2019
Merged

record restic restore progress in PodVolumeRestore #1854

merged 7 commits into from
Sep 10, 2019

Conversation

prydonius
Copy link
Contributor

depends on #1821

@prydonius prydonius requested review from nrb, skriss and carlisia September 6, 2019 23:16
@prydonius
Copy link
Contributor Author

Hmm, I'm not sure why the travis push job is running, but it's probably because I pushed the branch for #1821 to origin to have this be based off of it. @nrb is there a way to get the push job to only run on master?

skriss
skriss reviewed Sep 9, 2019
View reviewed changes
pkg/restic/exec_commands.go Outdated Show resolved Hide resolved
@nrb
Copy link
Contributor

nrb commented Sep 9, 2019

Hmm, I'm not sure why the travis push job is running, but it's probably because I pushed the branch for #1821 to origin to have this be based off of it. @nrb is there a way to get the push job to only run on master?

I think it's due to https://github.com/heptio/velero/blob/master/.travis.yml#L31, but I'm not sure we can turn it off because, based on my understanding, it won't work with tags :(

@prydonius
Copy link
Contributor Author

Ah okay, though it looks like it didn't run for the last commit on this?

carlisia
carlisia approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@carlisia carlisia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm.

@prydonius
Copy link
Contributor Author

ty, will rebase this now that #1821 is merged!

Adnan Abdulhussein added 4 commits September 10, 2019 11:41
record restic restore progress in PodVolumeRestore
47b6f43 
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
add progress output to velero describe restore --details
fe2c8a6 
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
test getVolumeSize
efd166e 
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
block on send to finish goroutine
5d15598 
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
@prydonius prydonius force-pushed the 1749-restic-restore-progress branch from f0740ec to 5d15598 Compare September 10, 2019 18:42
@prydonius prydonius changed the base branch from 1749-restic-progress to master September 10, 2019 18:42
@prydonius
Copy link
Contributor Author

Can't see why DCO would fail here

@carlisia
Copy link
Contributor

Weird. Maybe squashing them will make it happy.

@skriss skriss closed this Sep 10, 2019
@skriss skriss reopened this Sep 10, 2019
@skriss
Copy link
Contributor

skriss commented Sep 10, 2019

Not sure, seems to be complaining about past commits that are already in master..looks like I can manually override it to pass for now.

skriss
skriss reviewed Sep 10, 2019
View reviewed changes
Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good - I'll test it out this aft. Let's add a changelog for this too.

pkg/restic/exec_commands.go Outdated Show resolved Hide resolved
Adnan Abdulhussein added 3 commits September 10, 2019 13:06
remove sync import
5198b4a 
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
add changelog
f1e3de1 
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
make update
fa201ed 
Signed-off-by: Adnan Abdulhussein <aadnan@vmware.com>
@prydonius
Copy link
Contributor Author

Added a changelog and ran make update - PTAL!

skriss
skriss approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@skriss skriss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skriss skriss merged commit 23376e6 into vmware-tanzu:master Sep 10, 2019
@skriss skriss mentioned this pull request Sep 10, 2019
Closed
@prydonius prydonius deleted the 1749-restic-restore-progress branch September 10, 2019 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skriss skriss skriss approved these changes

@carlisia carlisia carlisia approved these changes

@nrb nrb Awaiting requested review from nrb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prydonius @nrb @carlisia @skriss