bug fix: don't panic on nil restic repo maintenance time (#2315)

* bug fix: don't panic on nil restic repo maintenance time Signed-off-by: Steve Kriss <krisss@vmware.com> * changelog Signed-off-by: Steve Kriss <krisss@vmware.com>
vmware-tanzu · Mar 5, 2020 · fd95a59 · fd95a59
1 parent bdb9145
commit fd95a59
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/changelogs/unreleased/2315-skriss b/changelogs/unreleased/2315-skriss
@@ -0,0 +1 @@
+bug fix: don't panic in `velero restic repo get` when last maintenance time is `nil`
diff --git a/pkg/cmd/util/output/restic_repo_printer.go b/pkg/cmd/util/output/restic_repo_printer.go
@@ -52,9 +52,11 @@ func printResticRepo(repo *v1.ResticRepository) []metav1.TableRow {
 		status = v1.ResticRepositoryPhaseNew
 	}
 
-	lastMaintenance := repo.Status.LastMaintenanceTime.String()
-	if repo.Status.LastMaintenanceTime.IsZero() {
+	var lastMaintenance string
+	if repo.Status.LastMaintenanceTime == nil || repo.Status.LastMaintenanceTime.IsZero() {
 		lastMaintenance = "<never>"
+	} else {
+		lastMaintenance = repo.Status.LastMaintenanceTime.String()
 	}
 
 	row.Cells = append(row.Cells,
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		bug fix: don't panic in `velero restic repo get` when last maintenance time is `nil`