-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation around minimum required permissions #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ashish-amarnath,
carlisia,
dsu-igeek,
nrb and
zubron
December 7, 2020 18:40
Signed-off-by: Justin Bertrand <justin.bertrand@canada.ca>
Signed-off-by: Justin Bertrand <justin.bertrand@canada.ca>
justbert
force-pushed
the
docs-azure-permissions
branch
from
December 7, 2020 18:41
51add80
to
6323a07
Compare
Signed-off-by: Justin Bertrand <justin.bertrand@canada.ca>
docs(permissions): removed unneeded permission for storage account. Signed-off-by: Justin Bertrand <justin.bertrand@canada.ca>
justbert
force-pushed
the
docs-azure-permissions
branch
from
December 7, 2020 18:54
208722d
to
ec0362a
Compare
Signed-off-by: Justin Bertrand <justin.bertrand@canada.ca>
Signed-off-by: Justin Bertrand <justin.bertrand@canada.ca>
I know that formatting and docs writing are not my strongest skills, so if it's better, I can also submit all the required info into an Issue and someone else can do a better job! :) |
carlisia
approved these changes
Dec 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thinking @justbert! Thanks for making our docs better. 👍
jenting
approved these changes
Feb 27, 2021
yvespp
pushed a commit
to yvespp/velero-plugin-for-microsoft-azure
that referenced
this pull request
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently in the midst of setting up the least required permissions by the plugin to perform the necessary operations and figured it would be good to upstream the information to allow others to adhere to the principle of least access.