Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Fixing windows node overlay template apply #778

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Fixing windows node overlay template apply #778

merged 1 commit into from
Oct 5, 2021

Conversation

knabben
Copy link
Member

@knabben knabben commented Oct 5, 2021

What this PR does / why we need it:
Finalizing the template conditional for windows feature flag and avoid applying unnecessary CRDs

Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:
Run a new cluster upgrade, metadata/tkg should be applied to the workload cluster.

Special notes for your reviewer:

Release note:

NONE

New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate kind label according to what type of issue is being addressed.

@knabben knabben requested a review from a team as a code owner October 5, 2021 22:16
@anujc25 anujc25 added kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging labels Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/778/20211005222956/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@knabben knabben changed the title Removing metadata/tkg annotation from CRS definition Fixing windows node overlay template apply Oct 5, 2021
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/778/20211005230136/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Cluster Generation A/B Results:
https://storage.googleapis.com/tkg-clustergen/778/20211005230354/clustergen.diff.txt
Author/reviewers:
Please review to verify that the effects on the generated cluster configurations are exactly what the PR intended, and give a thumbs-up if so.

Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-not-required kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants