Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Fix docker build in capabilities and features packages #765

Merged
merged 1 commit into from
Oct 5, 2021
Merged

Fix docker build in capabilities and features packages #765

merged 1 commit into from
Oct 5, 2021

Conversation

rajathagasthya
Copy link
Member

What this PR does / why we need it:

Both these Dockerfiles included specific directories for building
manager binary, but it seems like pkg/v1/buildinfo is now required as
it is being passed as a linker flag to all docker builds. This change
just copies all source code for building to prevent future breakages
like this.

Which issue(s) this PR fixes:

Fixes #764

Describe testing done for PR:

$ cd pkg/v1/sdk/capabilities
$ make docker-build

$ cd pkg/v1/sdk/features
$ make docker-build

Both succeeds.

Special notes for your reviewer:

Release note:

NONE

New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate kind label according to what type of issue is being addressed.

@rajathagasthya
Fix docker build in capabilities and features packages
be7a587 
Both these Dockerfiles included specific directories for building
manager binary, but it seems like `pkg/v1/buildinfo` is now required as
it is being passed as a linker flag to all docker builds. This change
just copies all source code for building to prevent future breakages
like this.
@rajathagasthya rajathagasthya added area/repo maintenance kind/bug PR/Issue related to a bug labels Oct 4, 2021
@rajathagasthya rajathagasthya requested a review from a team as a code owner October 4, 2021 19:04
yharish991
yharish991 approved these changes Oct 5, 2021
View reviewed changes
Copy link
Member

@yharish991 yharish991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@vijaykatam vijaykatam added the ok-to-merge PRs should be labelled with this before merging label Oct 5, 2021
@rajathagasthya rajathagasthya merged commit bcf7706 into vmware-tanzu:main Oct 5, 2021
@rajathagasthya rajathagasthya deleted the fix-docker-builds branch October 5, 2021 18:40
@rajaskakodkar rajaskakodkar mentioned this pull request Nov 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vijaykatam vijaykatam vijaykatam approved these changes

@yharish991 yharish991 yharish991 approved these changes

@vuil vuil Awaiting requested review from vuil

Assignees

@vuil vuil

@yharish991 yharish991

Labels
area/repo maintenance cla-not-required kind/bug PR/Issue related to a bug ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker builds are broken in capabilities and features packages
5 participants
@rajathagasthya @vijaykatam @yharish991 @vuil @vmwclabot