-
Notifications
You must be signed in to change notification settings - Fork 193
Conversation
So the lint issues appear to be from some other commits. |
Fix for lint issue has just merged. I think you will need to rebase on main to pick up the fix as it appears the job does not automatically rebase. |
Thanks for the addition, @timothysc I took the liberty to push cleanups and suggestions to the source branch. Hope that's alright. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
@@ -0,0 +1,47 @@ | |||
# Tanzu Framework Glossary | |||
|
|||
**Addon:** see definition of “Package.” Framework will be replacing this word with “package” over time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought: Not sure if this will happen because upstream projects(ex:https://github.com/kubernetes-sigs/cluster-addons) still refers to core things as addons and if we want to be upstream aligned with CAPI we may have to continue to use the term addon.
What this PR does / why we need it:
Adds a glossary of terms
Which issue(s) this PR fixes:
Fixes #339
Describe testing done for PR:
N/A
Special notes for your reviewer:
Release note:
None
cc @LappleApple