Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Adds glossary #741

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Adds glossary #741

merged 1 commit into from
Oct 2, 2021

Conversation

timothysc
Copy link
Contributor

What this PR does / why we need it:
Adds a glossary of terms

Which issue(s) this PR fixes:
Fixes #339

Describe testing done for PR:
N/A

Special notes for your reviewer:

Release note:
None

cc @LappleApple

@timothysc timothysc requested a review from a team as a code owner October 1, 2021 19:17
@timothysc
Copy link
Contributor Author

So the lint issues appear to be from some other commits.

@stmcginnis
Copy link
Contributor

Fix for lint issue has just merged. I think you will need to rebase on main to pick up the fix as it appears the job does not automatically rebase.

docs/glossary.md Outdated Show resolved Hide resolved
docs/glossary.md Outdated Show resolved Hide resolved
@vuil
Copy link
Contributor

vuil commented Oct 1, 2021

Thanks for the addition, @timothysc
Given a rebase is needed, I included a few nits that we may want to consider taking care of as well.

I took the liberty to push cleanups and suggestions to the source branch. Hope that's alright.

@vuil vuil added documentation area/repo maintenance ok-to-merge PRs should be labelled with this before merging labels Oct 1, 2021
@vuil vuil self-assigned this Oct 1, 2021
Copy link
Contributor

@vuil vuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@@ -0,0 +1,47 @@
# Tanzu Framework Glossary

**Addon:** see definition of “Package.” Framework will be replacing this word with “package” over time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought: Not sure if this will happen because upstream projects(ex:https://github.com/kubernetes-sigs/cluster-addons) still refers to core things as addons and if we want to be upstream aligned with CAPI we may have to continue to use the term addon.

@timothysc timothysc merged commit 5b2f6b1 into vmware-tanzu:main Oct 2, 2021
@vuil vuil added kind/documentation Categorizes issue or PR as related to documentation and removed documentation labels Mar 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/repo maintenance cla-not-required kind/documentation Categorizes issue or PR as related to documentation ok-to-merge PRs should be labelled with this before merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Framework Terms Glossary
5 participants