[DO-NOT-MERGE] TESTS: Discover Plugins from all active contexts and Support Plugin Name conflicts across different Targets #4049
Conversation
- Exclude admin plugins from k8s target - Remove default ContextType as k8s - Include sha256 in the plugin filename when storing
- Update catalog - Refactoring plugin manager functions to remove serverName - Add target flag to commands and integrate it with implementation Squash: Update unit tests Update go.mod Fix dependencies Rename ContextType to Target for Plugins Feature-flag the changes regarding plugin discovery Add GetAllCurrentContextMap and list Remove ContextType from discoverySource Add unit tests for GetAllCurrentContextsMap Refactor and fix unit tests Update helptext for target flag Fix linter errors Update go modules Update test files
This is required because of k8s targeted plugin still relies on
`current` field and we do not want to update that field when context for
tmc targeted context changes.
Scenario:
1. config.yaml looks like below
```
current: kind-test-cluster-2
currentContext:
tmc: tmc-unstable
k8s: kind-test-cluster-2
```
2. tanzu tkr get or tanzu k8s tkr get talks to kind-test-cluster-2
and returns the result.
3. tanzu tmc iam command should use currentContext.tmc and talk to
tmc-unstable endpoint.
4. If user does, tanzu context use tmc-dev to point to new tmc dev
endpoint, based on the existing behavior it will update the
currentContext.tmc as well as current to point to tmc-dev .
```
current: tmc-dev
currentContext:
tmc: tmc-dev
k8s: kind-test-cluster-2
```
5. Because, old tkr plugin still uses current to determine the
cluster to talk to tanzu k8s tkr get will not work anymore as
it is pointing to tmc endpoint.
|
/test install-vc7 |
|
Cluster Generation A/B Results: |
Codecov Report
@@ Coverage Diff @@
## main #4049 +/- ##
==========================================
- Coverage 48.22% 47.58% -0.64%
==========================================
Files 433 457 +24
Lines 43122 44740 +1618
==========================================
+ Hits 20795 21290 +495
- Misses 20343 21446 +1103
- Partials 1984 2004 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/test install-vc7 |
|
Cluster Generation A/B Results: |
anujc25
force-pushed
the
support-plugin-name-conflicts
branch
from
5221503
to
fea415e
Compare
|
/test install-vc7 |
|
Cluster Generation A/B Results: |
|
Cluster Generation A/B Results: |
What this PR does / why we need it
Creating a new PR from the branch on this repo. PR is same as #3961 and has been created to verify the pipeline runs when PR is created from branch on this repo.
Which issue(s) this PR fixes
Fixes #
Describe testing done for PR
Release note
Additional information
Special notes for your reviewer