Add actionlint GitHub workflow #1320

[seemiller]

What this PR does / why we need it

Adds the actionlint GitHub workflow, just like as implemented in the TCE repository.

Which issue(s) this PR fixes

Fixes #1320

Describe testing done for PR

Additional information

Special notes for your reviewer

The linter is reporting an error in the Post Cluster Generation Results As Comment workflow as defined in the .github/workflows/recv_providers.yaml file. The clustergen step is actually defined in the Provider Template Tests workflow, which is the prerequisite workflow. The action seems to run fine however, as comments are appearing in issues.

I've added a --ignore in the Makefile task to ignore this error and provide a discussion point.

.github/workflows/recv_providers.yaml:53:17: property "clustergen" is not defined in object type {read_artifact: {outcome: string; outputs: {string => string}; conclusion: string}; time: {conclusion: string; outcome: string; outputs: {string => string}}} [expression]
   |
53 |         if: ${{ steps.clustergen.outputs.diffstatus == 0 }}
   |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[github-actions]

Hi @seemiller! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Framework better.

[codecov]

Codecov Report

Merging #3042 (0ad4b9f) into main (1c29154) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3042      +/-   ##
==========================================
- Coverage   44.23%   44.22%   -0.01%     
==========================================
  Files         416      416              
  Lines       42143    42143              
==========================================
- Hits        18641    18639       -2     
- Misses      21780    21781       +1     
- Partials     1722     1723       +1     

Impacted Files	Coverage Δ
...ons/controllers/packageinstallstatus_controller.go	77.99% <0.00%> (-1.16%)	⬇️
cmd/cli/plugin/tkr/v1alpha3/os.go	74.35% <0.00%> (+0.85%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c69b9e...0ad4b9f. Read the comment docs.

[vuil]

latest (v1.6.17) seems to be croaking with go 1.17. I did verify version v1.6.16 works. Should we switch to it?

Also nice catch and and thanks from bringing the invalid property issue to attention, @seemiller !

I have a PR out to fix it: #3360
Once that is addressed, we can remove L487

[vuil]

#3360 is merged

[vuil]

We have so far assigned the self-hosted runners to only run the workflows that absolutely need them. This check is likely something we can use standard GH runners to run.