-
Notifications
You must be signed in to change notification settings - Fork 193
Conversation
Hi @seemiller! And thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Tanzu Framework better. |
Codecov Report
@@ Coverage Diff @@
## main #3042 +/- ##
==========================================
- Coverage 44.23% 44.22% -0.01%
==========================================
Files 416 416
Lines 42143 42143
==========================================
- Hits 18641 18639 -2
- Misses 21780 21781 +1
- Partials 1722 1723 +1
Continue to review full report at Codecov.
|
@@ -482,6 +482,10 @@ lint: tools go-lint doc-lint misspell yamllint ## Run linting and misspell check | |||
misspell: | |||
hack/check/misspell.sh | |||
|
|||
actionlint: | |||
go install github.com/rhysd/actionlint/cmd/actionlint@latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
latest
(v1.6.17) seems to be croaking with go 1.17. I did verify version v1.6.16 works. Should we switch to it?
Also nice catch and and thanks from bringing the invalid property issue to attention, @seemiller !
I have a PR out to fix it: #3360
Once that is addressed, we can remove L487
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#3360 is merged
@@ -0,0 +1,4 @@ | |||
self-hosted-runner: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have so far assigned the self-hosted runners to only run the workflows that absolutely need them. This check is likely something we can use standard GH runners to run.
What this PR does / why we need it
Adds the actionlint GitHub workflow, just like as implemented in the TCE repository.
Which issue(s) this PR fixes
Fixes #1320
Describe testing done for PR
Additional information
Special notes for your reviewer
The linter is reporting an error in the
Post Cluster Generation Results As Comment
workflow as defined in the.github/workflows/recv_providers.yaml
file. Theclustergen
step is actually defined in theProvider Template Tests
workflow, which is the prerequisite workflow. The action seems to run fine however, as comments are appearing in issues.I've added a
--ignore
in the Makefile task to ignore this error and provide a discussion point.