-
Notifications
You must be signed in to change notification settings - Fork 193
Initialize variable as empty if not passed; fixes #2876 #2878
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Matt Bentley <mbentley@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #2878 +/- ##
=======================================
Coverage 43.82% 43.83%
=======================================
Files 414 414
Lines 41295 41295
=======================================
+ Hits 18097 18101 +4
+ Misses 21503 21500 -3
+ Partials 1695 1694 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for submitting the issue and fixing it!
@mbentley please see the link in the vmwclabot check for details on signing a CLA as a contributor to vmware-tanzu projects like this one. |
As a VMware employee, I've gone through the steps suggested when I originally opened #2877 and am now a member of the GitHub org. Anything else I am needing to do? Also checking internally to see if anyone might have any ideas why the @vmwclabot is asking for the CLA to be signed when I am a member of the |
@vuil - looks like everything should be OK from a merging standpoint; someone was able to fix the CLA issue. |
Signed-off-by: Matt Bentley mbentley@vmware.com
What this PR does / why we need it
Addresses unexpected behavior in airgap script
Which issue(s) this PR fixes
Fixes #2876
Describe testing done for PR
Validated that the script runs with the change.
Release note
n/a - not really release note worthy
PR Checklist
Additional information
Special notes for your reviewer