Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Kickstart UI: refactor labels #1620

Open
1 of 10 tasks
swalner-vmware opened this issue Feb 3, 2022 · 0 comments · May be fixed by #1730
Open
1 of 10 tasks

Kickstart UI: refactor labels #1620

swalner-vmware opened this issue Feb 3, 2022 · 0 comments · May be fixed by #1730
Assignees
@2022amanda
Labels
area/ui Specific UI issue/enhancement area/ux UX related kind/cleanup Categorizes issue or PR as related to cleaning up code, process not-core-cli
Milestone
v.Next

Comments

@swalner-vmware
Copy link
Contributor

swalner-vmware commented Feb 3, 2022 •
edited
Loading

Problem description
We currently have two different implementation of labels for load-balancer and metadata steps. It would be nice to create a component and re-use it between the two steps.
In addition, we can use a simple array of KeyValuePairs for the backing data structure. This would permit the user to edit both the key and value fields for existing labels.
We can allow a trashcan icon when there is only one key-value pair and have it simply clear the values out of the fields.
(That allows consistency: there is always a trashcan icon.)

Affected product area (please put an X in all that apply)

  • APIs
  • Addons
  • CLI
  • Docs
  • IAM
  • Installation
  • Plugin
  • Security
  • Test and Release
  • User Experience

Expected behavior

Steps to reproduce the bug

Version (include the SHA if the version is not obvious)

Environment where the bug was observed (cloud, OS, etc)

Relevant Debug Output (Logs, manifests, etc)
@swalner-vmware swalner-vmware added kind/cleanup Categorizes issue or PR as related to cleaning up code, process area/ux UX related area/ui Specific UI issue/enhancement labels Feb 3, 2022
@swalner-vmware swalner-vmware added this to the v.Next milestone Feb 3, 2022
@swalner-vmware swalner-vmware self-assigned this Feb 3, 2022
@2022amanda 2022amanda linked a pull request Feb 23, 2022 that will close this issue
Open
3 tasks
miclettej pushed a commit that referenced this issue Jun 6, 2022
@mpanchajanya
Kickstart UI: Refactors Labels Component to Shared TKG Labels (#2515)
e723ae6 
* Issue #1620 - TKG Labels

* update lock

* add spaces on imports
ankeesler pushed a commit to ankeesler/tanzu-framework that referenced this issue Jun 14, 2022
@mpanchajanya @ankeesler
Kickstart UI: Refactors Labels Component to Shared TKG Labels (vmware…
bd86b53 
…-tanzu#2515)

* Issue vmware-tanzu#1620 - TKG Labels

* update lock

* add spaces on imports
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@2022amanda 2022amanda

Labels
area/ui Specific UI issue/enhancement area/ux UX related kind/cleanup Categorizes issue or PR as related to cleaning up code, process not-core-cli
Projects
None yet
Milestone
v.Next
Development

Successfully merging a pull request may close this issue.

Refactor labels 2022amanda/tanzu-framework
3 participants
@saji-pivotal @swalner-vmware @2022amanda