Fix broken "read only" fields added in v0.11.0. #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These fields were changed as a minor hardening attempt when we switched to Distroless, but I bungled the field names and we never noticed because Kapp doesn't apply API validations. This change fixes the field names so they act as was originally intended. We should also follow up with a change that validates all of our installation manifest in CI. Signed-off-by: Matt Moyer <moyerm@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #835 +/- ##
==========================================
- Coverage 78.64% 78.62% -0.03%
==========================================
Files 129 129
Lines 8945 8945
==========================================
- Hits 7035 7033 -2
- Misses 1681 1684 +3
+ Partials 229 228 -1
Continue to review full report at Codecov.
|
enj
approved these changes
Sep 2, 2021
…o we can be sure that our manifests pass API validation. We had this for some components, but not the ones that mattered the most. Signed-off-by: Matt Moyer <moyerm@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields were changed as a minor hardening attempt when we switched to Distroless, but I bungled the field names and we never noticed because Kapp doesn't apply API validations.
This change fixes the field names so they act as was originally intended. We should also follow up with a change that validates all of our installation manifest in CI.
Thanks to Jeremy Calcamuggio in Kubernetes Slack for raising this issue.
Release note: