Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClusterIP service to impersonator-config-controller informer. #752

Conversation

mattmoyer
Copy link
Contributor

Prior to this fix, this controller did not correctly react to changes to the ClusterIP service. It would still eventually react with a long delay due to our 5 minute resync interval.

Release note:

The Concierge now correctly reacts to changes in the impersonation proxy ClusterIP service immediately.

Prior to this fix, this controller did not correctly react to changes to the ClusterIP service. It would still eventually react with a long delay due to our 5 minute resync interval.

Signed-off-by: Matt Moyer <moyerm@vmware.com>
@mattmoyer mattmoyer added the bug Something isn't working label Jul 28, 2021
@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #752 (5f67905) into main (8afbb4e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
+ Coverage   79.87%   79.88%   +0.01%     
==========================================
  Files         124      124              
  Lines        8352     8357       +5     
==========================================
+ Hits         6671     6676       +5     
  Misses       1463     1463              
  Partials      218      218              
Impacted Files Coverage Δ
...ntroller/impersonatorconfig/impersonator_config.go 93.15% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8afbb4e...5f67905. Read the comment docs.

@mattmoyer mattmoyer enabled auto-merge July 28, 2021 17:08
@mattmoyer mattmoyer merged commit 1f51159 into vmware-tanzu:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla-not-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants