Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI compilation on Windows. #746

Merged
merged 1 commit into from
Jul 27, 2021

Conversation

mattmoyer
Copy link
Contributor

@mattmoyer mattmoyer commented Jul 27, 2021

It turns out that syscall.Stdin is of type int on Linux and macOS, but not on Windows (it's syscall.Handle). This should now be portable and do all the required type casting on every platform.

This is a recently introduced regression (in #687), so it has never been released. We are also adjusting the CI pipeline to include a Windows CLI compilation in the PR pipeline (which allowed this regression to slip into main unnoticed).

Release note:

NONE

It turns out that `syscall.Stdin` is of type `int` on Linux and macOS, but not on Windows (it's `syscall.Handle`). This should now be portable and do all the require type casting on every platform.

Signed-off-by: Matt Moyer <moyerm@vmware.com>
@mattmoyer mattmoyer added the bug Something isn't working label Jul 27, 2021
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #746 (8e8af51) into main (d5759c9) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #746   +/-   ##
=======================================
  Coverage   79.85%   79.86%           
=======================================
  Files         124      124           
  Lines        8346     8347    +1     
=======================================
+ Hits         6665     6666    +1     
  Misses       1463     1463           
  Partials      218      218           
Impacted Files Coverage Δ
pkg/oidcclient/login.go 89.75% <50.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5759c9...8e8af51. Read the comment docs.

@mattmoyer mattmoyer merged commit 22a66c1 into vmware-tanzu:main Jul 27, 2021
@mattmoyer mattmoyer deleted the fix-windows-build branch July 27, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cla-not-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants