Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make host name parsing case-insensitive #2022

Merged

Conversation

ashish-amarnath
Copy link
Member

bug-fix: make host name parsing case-insensitive

Release note:

bug fix: host names with upper case characters were previously considered invalid. Pinniped is now insensitive to casing on host names.

Signed-off-by: Ashish Amarnath <ashish.amarnath@broadcom.com>

Co-authored-by: Ryan Richard <richardry@vmware.com>
@joshuatcasey
Copy link
Member

The only integration tests that were failing on commit 7c7f0fdae3470c7cb6c3aeb3972b9daede7f866e were flakes, so I'll rebase on latest main and we'll try again.

@ashish-amarnath ashish-amarnath merged commit 66f005f into vmware-tanzu:main Jul 30, 2024
43 checks passed
@ashish-amarnath ashish-amarnath deleted the host-name-case-insensitve branch July 30, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants