-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix authenticators bug: stop allowing usage when validation fails #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2013 +/- ##
==========================================
+ Coverage 30.68% 30.73% +0.04%
==========================================
Files 365 365
Lines 60594 60644 +50
==========================================
+ Hits 18591 18636 +45
- Misses 41468 41472 +4
- Partials 535 536 +1 ☔ View full report in Codecov by Sentry. |
cfryanr
force-pushed
the
authenticators_bugfix
branch
from
July 16, 2024 16:59
7b20bb7
to
b5a509f
Compare
cfryanr
changed the title
WIP: fix authenticators bug, stop allowing usage when validation fails
fix authenticators bug, stop allowing usage when validation fails
Jul 16, 2024
cfryanr
changed the title
fix authenticators bug, stop allowing usage when validation fails
fix authenticators bug: stop allowing usage when validation fails
Jul 16, 2024
internal/controller/authenticator/jwtcachefiller/jwtcachefiller.go
Outdated
Show resolved
Hide resolved
internal/controller/authenticator/webhookcachefiller/webhookcachefiller_test.go
Outdated
Show resolved
Hide resolved
internal/controller/authenticator/webhookcachefiller/webhookcachefiller_test.go
Show resolved
Hide resolved
joshuatcasey
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the spec of a JWTAuthenticator or WebhookAuthenticator changes, and if the resource goes from being valid to being invalid, then that authenticator should not be used anymore. This PR removes it from the in-memory cache so it cannot be used during auth anymore.
This PR also reduces how often the WebhookAuthenticators are revalidated. When the spec has not changed since it was previously validated, then skip performing validations and leave it in the in-memory cache for usage during auth.
These changes also have the side benefit of making the code for controller for WebhookAuthenticators and the controller for JWTAuthenticator more similar/consistent.
Release note: