Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary warning log message #2010

Merged
merged 1 commit into from
Jul 12, 2024
Merged

remove unnecessary warning log message #2010

merged 1 commit into from
Jul 12, 2024

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Jul 10, 2024

This message is not needed because the IDP chooser page will take care of the case where a browser-based authorization flow did not request any specific IDP. For browserless flows (only allowed for the pinniped-cli client), the client must request a specific IDP (except in backwards-compatibility mode) because there is no browser in which to show the IDP chooser page. Failing to request a specific IDP in a browserless flow will result in a helpful error message being returned.

Release note:

NONE

This message is not needed because the IDP chooser page will take
care of the case where a browser-based authorization flow did not
request any specific IDP. For browserless flows (only allowed for
the `pinniped-cli` client), the client must request a specific IDP
(except in backwards-compatibility mode) because there is no browser
in which to show the IDP chooser page. Failing to request a specific
IDP in a browserless flow will result in a helpful error message
being returned.
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.67%. Comparing base (dd80627) to head (e5cfa52).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2010      +/-   ##
==========================================
- Coverage   30.69%   30.67%   -0.03%     
==========================================
  Files         365      365              
  Lines       60616    60594      -22     
==========================================
- Hits        18609    18589      -20     
+ Misses      41470    41469       -1     
+ Partials      537      536       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashish-amarnath
Copy link
Member

The CI job is failing, but unlikely it is related to this change.

@cfryanr
Copy link
Member Author

cfryanr commented Jul 10, 2024

I'm not sure what is causing these integration test failure flakes. They all look the same, which is a dial tcp i/o timeout while trying to make a Kubernetes API call to a remote Kind cluster. Each of the four failed jobs encountered this problem only once (out of hundreds or maybe thousands of API calls made by the whole integration test suite), and each failed on a different Kubernetes API.

This is strange because it seems to be happening a lot lately, but did not happen often previously.

@cfryanr cfryanr merged commit b7d1c3f into main Jul 12, 2024
39 of 43 checks passed
@cfryanr cfryanr deleted the remove_warning branch July 12, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants