Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite flaky category test #1992

Merged
merged 1 commit into from
Jun 18, 2024
Merged

rewrite flaky category test #1992

merged 1 commit into from
Jun 18, 2024

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Jun 17, 2024

The integration test called TestGetPinnipedCategory has been very flaky in CI lately. I reviewed what it tries to cover and rewrote it. Hopefully this will make it less flaky, and hopefully the new implementation is more clear in what it is trying to cover.

Note that which specific custom APIs should be included in the "pinniped" category is already covered by this other test and so it does not need to be covered by TestGetPinnipedCategory.

I retained the parts of the test which show that listing the resources of the aggregated APIs should work and should always return an empty list, but I rewrote that too.

Release note:

Test-only changes.

NONE

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.68%. Comparing base (b50d138) to head (88bcdba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1992   +/-   ##
=======================================
  Coverage   30.68%   30.68%           
=======================================
  Files         365      365           
  Lines       60617    60617           
=======================================
+ Hits        18598    18599    +1     
  Misses      41482    41482           
+ Partials      537      536    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashish-amarnath ashish-amarnath merged commit 84308f3 into main Jun 18, 2024
43 checks passed
@ashish-amarnath ashish-amarnath deleted the update_flaky_test branch June 18, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants