Add proposal for CA bundles from secret refs #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuatcasey
force-pushed
the
jtc/add-proposal-for-secret-ref-ca-bundles
branch
3 times, most recently
from
73e7797
to
d2c4956
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1984 +/- ##
=======================================
Coverage 30.68% 30.68%
=======================================
Files 365 365
Lines 60617 60617
=======================================
+ Hits 18599 18602 +3
+ Misses 41481 41479 -2
+ Partials 537 536 -1 ☔ View full report in Codecov by Sentry. |
joshuatcasey
force-pushed
the
jtc/add-proposal-for-secret-ref-ca-bundles
branch
3 times, most recently
from
f2cf526
to
259a7f3
Compare
joshuatcasey
force-pushed
the
jtc/add-proposal-for-secret-ref-ca-bundles
branch
from
259a7f3
to
3e55ecf
Compare
joshuatcasey
commented
Jun 12, 2024
cfryanr
reviewed
Jun 12, 2024
cfryanr
reviewed
Jun 19, 2024
cfryanr
reviewed
Jun 19, 2024
cfryanr
reviewed
Jun 19, 2024
cfryanr
reviewed
Jun 19, 2024
cfryanr
reviewed
Jun 19, 2024
cfryanr
reviewed
Jun 19, 2024
cfryanr
reviewed
Jun 19, 2024
cfryanr
reviewed
Jun 19, 2024
cfryanr
reviewed
Jun 19, 2024
cfryanr
reviewed
Jun 19, 2024
cfryanr
reviewed
Jun 19, 2024
cfryanr
reviewed
Jun 19, 2024
cfryanr
reviewed
Jun 19, 2024
ashish-amarnath
force-pushed
the
jtc/add-proposal-for-secret-ref-ca-bundles
branch
3 times, most recently
from
1606600
to
14911ea
Compare
ashish-amarnath
force-pushed
the
jtc/add-proposal-for-secret-ref-ca-bundles
branch
from
14911ea
to
cbd04c4
Compare
cfryanr
reviewed
Jun 19, 2024
| --- | ||
| title: "Source Certificate Authority Data from Secrets and ConfigMaps into Pinniped Custom Resources" | ||
| authors: [ "@cfryanr", "@joshuatcasey" , "@ashish-amarnath"] | ||
| status: "proposed" |
There was a problem hiding this comment.
Please feel free to change the status to "approved" before merging this PR.
|
Feel free to merge without CI passing because this PR only adds a proposal markdown document, which is not tested by CI in any way. |
Signed-off-by: Ashish Amarnath <ashish.amarnath@broadcom.com>
ashish-amarnath
force-pushed
the
jtc/add-proposal-for-secret-ref-ca-bundles
branch
from
cbd04c4
to
e38f082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add proposal for CA bundles from secret refs
rendered markdown