Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle another github login interstitial page #1983

Merged
merged 2 commits into from
Jun 6, 2024

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Jun 6, 2024

Handle another page that can happen during github login in integration tests.

The page looks like this:
image

Tests that see this page should try to click the "skip" link to move past it.

Release note:

NONE

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 30.60%. Comparing base (e9fa98e) to head (1fe6f2e).

Files Patch % Lines
test/testlib/browsertest/browsertest.go 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1983      +/-   ##
==========================================
- Coverage   30.61%   30.60%   -0.02%     
==========================================
  Files         363      363              
  Lines       60481    60492      +11     
==========================================
- Hits        18518    18514       -4     
- Misses      41429    41443      +14     
- Partials      534      535       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuatcasey joshuatcasey changed the title handle another githug login interstitial page handle another github login interstitial page Jun 6, 2024
@cfryanr cfryanr force-pushed the handle_another_github_interstitial branch from f288592 to 1fe6f2e Compare June 6, 2024 18:00
@joshuatcasey joshuatcasey merged commit b483409 into main Jun 6, 2024
43 checks passed
@joshuatcasey joshuatcasey deleted the handle_another_github_interstitial branch June 6, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants