Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use plog.Logger instead of logr.Logger wherever possible #1949

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

joshuatcasey
Copy link
Member

Use plog.Logger instead of logr.Logger wherever possible

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 80.20833% with 19 lines in your changes missing coverage. Please review.

Project coverage is 30.59%. Comparing base (247ac10) to head (011d6ba).

Files Patch % Lines
internal/plog/testing.go 53.84% 6 Missing ⚠️
pkg/oidcclient/login.go 87.09% 4 Missing ⚠️
internal/controllermanager/prepare_controllers.go 0.00% 3 Missing ⚠️
cmd/pinniped/cmd/oidc_client_options.go 0.00% 2 Missing ⚠️
cmd/pinniped/cmd/login_oidc.go 66.66% 1 Missing ⚠️
...ntroller/impersonatorconfig/impersonator_config.go 96.55% 1 Missing ⚠️
internal/controller/kubecertagent/kubecertagent.go 0.00% 1 Missing ⚠️
...onfig/oidcupstreamwatcher/oidc_upstream_watcher.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1949      +/-   ##
==========================================
- Coverage   30.61%   30.59%   -0.02%     
==========================================
  Files         363      363              
  Lines       60492    60516      +24     
==========================================
- Hits        18518    18516       -2     
- Misses      41440    41467      +27     
+ Partials      534      533       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuatcasey joshuatcasey marked this pull request as ready for review June 11, 2024 17:51
@cfryanr cfryanr enabled auto-merge June 11, 2024 22:35
@cfryanr cfryanr merged commit 80e1fee into main Jun 12, 2024
43 checks passed
@cfryanr cfryanr deleted the jtc/remove-logr-logger branch June 12, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants