Enforce import aliases #1947
Merged
Enforce import aliases #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuatcasey
force-pushed
the
jtc/add-importas-linter
branch
from
e920919
to
d18695f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1947 +/- ##
==========================================
- Coverage 30.60% 30.59% -0.01%
==========================================
Files 363 363
Lines 60492 60492
==========================================
- Hits 18515 18510 -5
- Misses 41443 41447 +4
- Partials 534 535 +1 ☔ View full report in Codecov by Sentry. |
joshuatcasey
force-pushed
the
jtc/add-importas-linter
branch
2 times, most recently
from
569fcd8
to
166fab0
Compare
joshuatcasey
force-pushed
the
jtc/add-importas-linter
branch
from
166fab0
to
f7d5877
Compare
…/apimachinery/pkg/api/errors'
- k8s.io/apimachinery/pkg/apis/meta/v1 - k8s.io/api/core/v1 - github.com/coreos/go-oidc/v3/oidc - github.com/ory/fosite/handler/oauth2 - go.pinniped.dev/generated/latest/apis/concierge/authentication/v1alpha1
- go.pinniped.dev/generated/latest/apis/supervisor/clientsecret/v1alpha1 - go.pinniped.dev/internal/concierge/scheme
…f 'interface{}'
Enforce importas:
- go.pinniped.dev/generated/latest/apis/supervisor/config/v1alpha1
- go.pinniped.dev/generated/latest/apis/supervisor/idp/v1alpha1
- go.pinniped.dev/generated/latest/apis/concierge/config/v1alpha1 - go.pinniped.dev/generated/latest/client/concierge/clientset/versioned - go.pinniped.dev/generated/latest/client/concierge/clientset/versioned/scheme - go.pinniped.dev/generated/latest/client/supervisor/clientset/versioned - go.pinniped.dev/generated/latest/client/supervisor/clientset/versioned/scheme
- go.pinniped.dev/generated/latest/client/concierge/clientset/versioned/fake - go.pinniped.dev/generated/latest/client/supervisor/clientset/versioned/fake - go.pinniped.dev/generated/latest/client/concierge/informers/externalversions - go.pinniped.dev/generated/latest/client/supervisor/informers/externalversions
joshuatcasey
force-pushed
the
jtc/add-importas-linter
branch
from
f7d5877
to
2f9df8c
Compare
cfryanr
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enforce import aliases