Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI deciding if token exchange needed should not look at ID token expiry #1873

Merged
merged 3 commits into from
Feb 23, 2024
Merged

CLI deciding if token exchange needed should not look at ID token expiry #1873

merged 3 commits into from
Feb 23, 2024

Commits on Feb 23, 2024

  1. CLI deciding if token exchange needed should not look at ID token expiry 

    This fixes a small mistake in PR #1864. When the "pinniped login oidc"
CLI command is deciding if the RFC8693 token exchange is needed, it
should not look at the expiry of the ID token. This mistake would cause
the RFC8693 token exchange to happen when the OIDC provider is not
a Pinniped Supervisor, which would fail because most other providers
do not support that type of token exchange.

It does not matter if the current ID token is close to expiring when
deciding if the RFC8693 token exchange is needed, because the token
exchange is going to yield a new ID token anyway. It does matter if the
current ID token is close to expiring if the CLI decides that it is
not going to perform the token exchange, and this commit does not change
that logic.
    @cfryanr
    cfryanr committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    01d6bdb View commit details
    Browse the repository at this point in the history

  2. Add hack/prepare-jwtauthenticator-on-kind.sh

    @cfryanr
    cfryanr committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    daec673 View commit details
    Browse the repository at this point in the history

  3. Update configure-concierge-jwt.md doc with clarifications

    @cfryanr
    cfryanr committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    64b0e69 View commit details
    Browse the repository at this point in the history