Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade fosite to latest version #1866

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Upgrade fosite to latest version #1866

merged 3 commits into from
Feb 13, 2024

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Feb 13, 2024

Upgrade fosite to the latest version, which includes this bug fix ory/fosite#793 from me.

As a result, the Pinniped Supervisor will be able to remove oidc session storage Secrets more efficiently.

It also included some other unrelated changes, and our tests needed to be updated to account for those changes as well.

Release note:

None.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (485b227) 38.66% compared to head (ceb9973) 38.68%.

Files Patch % Lines
.../controller/supervisorstorage/garbage_collector.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1866      +/-   ##
==========================================
+ Coverage   38.66%   38.68%   +0.01%     
==========================================
  Files         335      335              
  Lines       43615    43626      +11     
==========================================
+ Hits        16865    16876      +11     
+ Misses      26247    26246       -1     
- Partials      503      504       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfryanr cfryanr merged commit 719cd75 into main Feb 13, 2024
39 checks passed
@cfryanr cfryanr deleted the upgrade_fosite_feb_2024 branch February 13, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants