Add proposal for Authenticating Users via GitHub #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quick ref to your POC: session token lifetime & length: #1857 |
cfryanr
force-pushed
the
github_proposal
branch
from
253a0dc
to
fabeeb2
Compare
joshuatcasey
reviewed
Mar 8, 2024
cfryanr
commented
Mar 12, 2024
cfryanr
commented
Mar 19, 2024
cfryanr
commented
Mar 25, 2024
cfryanr
force-pushed
the
github_proposal
branch
from
fabeeb2
to
a3ceee8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
+ Coverage 38.56% 38.58% +0.01%
==========================================
Files 350 350
Lines 44514 44514
==========================================
+ Hits 17168 17174 +6
+ Misses 26831 26826 -5
+ Partials 515 514 -1 ☔ View full report in Codecov by Sentry. |
cfryanr
force-pushed
the
github_proposal
branch
from
a3ceee8
to
2af6f4c
Compare
joshuatcasey
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rendered proposal text can be viewed here (until this PR is merged, and then it could be viewed here).