-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve JWTAuthenticator Status #1851
Merged
Merged
Commits on Feb 27, 2024
-
Add .Status to JWTAuthenticator with Conditions,Phase
- "Ready" condition & supporting conditions - Legacy "Phase" for convenience - Refactor newCachedJWTAuthenticator() func to improve ability to provide additional conditions - Update JWTAuthenticator.Status type - Update RBAC for SA to get/watch/update JWTAuthenticator.Status - Update logger to plog, add tests for logs & statuses - update Sync() to reduce enqueue when error is config/user managed, perhaps remove validateJWKSResponse()
Configuration menu - View commit details
-
Copy full SHA for a4447fa - Browse repository at this point
Copy the full SHA a4447faView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd14a57 - Browse repository at this point
Copy the full SHA fd14a57View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4763934 - Browse repository at this point
Copy the full SHA 4763934View commit details -
- some format updates - add timestamp to test - fix order of expect,actual in some assertions - remove some commented code no longer needed
Configuration menu - View commit details
-
Copy full SHA for 084c311 - Browse repository at this point
Copy the full SHA 084c311View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09bd51f - Browse repository at this point
Copy the full SHA 09bd51fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a633ad - Browse repository at this point
Copy the full SHA 1a633adView commit details -
Add integration tests for JWTAuthenticators
- paired with changes to e2e_test.go, adds Status.Condition assertions around JWTAuthenticators
Configuration menu - View commit details
-
Copy full SHA for 73e4d31 - Browse repository at this point
Copy the full SHA 73e4d31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c7e704 - Browse repository at this point
Copy the full SHA 1c7e704View commit details -
Configuration menu - View commit details
-
Copy full SHA for 42acf8d - Browse repository at this point
Copy the full SHA 42acf8dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 868ff9e - Browse repository at this point
Copy the full SHA 868ff9eView commit details -
Update jwtauthenticator unit tests to check actions
- Add test to verify timestamps are particularly updated - Improve diff output in tests for actions - Make jwtauthenticator status tests parallel - Update copyright headers in multiple files
Configuration menu - View commit details
-
Copy full SHA for e8482ab - Browse repository at this point
Copy the full SHA e8482abView commit details -
Configuration menu - View commit details
-
Copy full SHA for f498cb3 - Browse repository at this point
Copy the full SHA f498cb3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.