Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JWTAuthenticator Status #1851

Merged
merged 12 commits into from
Feb 28, 2024
Merged

Improve JWTAuthenticator Status #1851

merged 12 commits into from
Feb 28, 2024

Commits on Feb 27, 2024

  1. Add .Status to JWTAuthenticator with Conditions,Phase

    - "Ready" condition & supporting conditions
    - Legacy "Phase" for convenience
    - Refactor newCachedJWTAuthenticator() func
      to improve ability to provide additional conditions
    - Update JWTAuthenticator.Status type
    - Update RBAC for SA to get/watch/update JWTAuthenticator.Status
    - Update logger to plog, add tests for logs & statuses
    - update Sync() to reduce enqueue when error is config/user managed, perhaps remove validateJWKSResponse()
    benjaminapetersen authored and cfryanr committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a4447fa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fd14a57 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4763934 View commit details
    Browse the repository at this point in the history
  4. Improve jwtcachefiller tests

    - some format updates
    - add timestamp to test
    - fix order of expect,actual in some assertions
    - remove some commented code no longer needed
    benjaminapetersen authored and cfryanr committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    084c311 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    09bd51f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1a633ad View commit details
    Browse the repository at this point in the history
  7. Add integration tests for JWTAuthenticators

    - paired with changes to e2e_test.go, adds Status.Condition assertions
      around JWTAuthenticators
    benjaminapetersen authored and cfryanr committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    73e4d31 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1c7e704 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    42acf8d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    868ff9e View commit details
    Browse the repository at this point in the history
  11. Update jwtauthenticator unit tests to check actions

    - Add test to verify timestamps are particularly updated
    - Improve diff output in tests for actions
    - Make jwtauthenticator status tests parallel
    - Update copyright headers in multiple files
    benjaminapetersen authored and cfryanr committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e8482ab View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f498cb3 View commit details
    Browse the repository at this point in the history