Support new golang fips compiler #1841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1841 +/- ##
=======================================
Coverage 79.09% 79.10%
=======================================
Files 173 173
Lines 16207 16201 -6
=======================================
- Hits 12819 12815 -4
+ Misses 3068 3066 -2
Partials 320 320 ☔ View full report in Codecov by Sentry. |
cfryanr
force-pushed
the
new_fips_compiler
branch
from
0513827
to
8bc7b67
Compare
|
Just to create some cross-link reference for a related issue: #1605 |
The release of Go 1.21.6 includes the new boring crypto when compiling with FIPS enabled. See https://go.dev/doc/devel/release#go1.21.0 and golang/go#64717. This new version of boring crypto allows the use of TLS v1.3 for the first time, so we changed the Pinniped code to use TLS v1.3 where appropriate when compiled with the FIPS compiler. It also changed the allowed TLS v1.2 ciphers, so we updated those as well. After this commit, the project must be compiled by at least Go v1.21.6 when compiling in fips mode. The hack/Dockerfile_fips was already updated to use that version of Go in a previous commit. Co-authored-by: Benjamin A. Petersen <ben@benjaminapetersen.me>
cfryanr
force-pushed
the
new_fips_compiler
branch
from
8bc7b67
to
50e4d6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the new Go FIPS compiler which was upgraded inside Go 1.21.6
The release of Go 1.21.6 includes the new boring crypto when compiling with FIPS enabled. See https://go.dev/doc/devel/release#go1.21.0 (search for 1.21.6 in that doc) and golang/go#64717.
This new version of boring crypto allows the use of TLS v1.3 for the first time, so we changed the Pinniped code to use TLS v1.3 where appropriate when compiled with the FIPS compiler. It also changed the allowed TLS v1.2 ciphers, so we updated those as well (it appears to have dropped
TLS_RSA_WITH_AES_128_GCM_SHA256andTLS_RSA_WITH_AES_256_GCM_SHA384).After this commit, the project must be compiled by at least Go v1.21.6 when compiling in fips mode. The
hack/Dockerfile_fipswas already updated to use that version of Go in a previous commit.Release note:
Update February 8, 2024: Much of this work had to be reverted when Go downgraded goboring. See #1863.