Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, including Kube packages to v0.29.0 #1825

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Jan 3, 2024

There are some significant changes introduced by the Kube 1.29 libs. This PR:

Release note:

Updated project dependencies

@cfryanr cfryanr marked this pull request as draft January 3, 2024 21:34
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (659224a) 79.11% compared to head (c7299f4) 79.08%.

Files Patch % Lines
internal/crypto/ptls/ptls.go 0.00% 16 Missing ⚠️
internal/concierge/server/server.go 0.00% 9 Missing ⚠️
internal/concierge/impersonator/impersonator.go 83.33% 0 Missing and 1 partial ⚠️
internal/config/featuregates/featuregates.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
- Coverage   79.11%   79.08%   -0.04%     
==========================================
  Files         173      173              
  Lines       16178    16207      +29     
==========================================
+ Hits        12800    12817      +17     
- Misses       3058     3070      +12     
  Partials      320      320              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfryanr
Copy link
Member Author

cfryanr commented Jan 4, 2024

Note: Before we merge, I want to squash the commits. There was an intermediate approach in one of the commits which was then rewritten in a later commit. If everything works, there is no need to keep the intermediate commits.

@cfryanr cfryanr marked this pull request as ready for review January 4, 2024 20:32
@cfryanr cfryanr changed the title WIP: Update dependencies, including Kube packages to v0.29.0 Update dependencies, including Kube packages to v0.29.0 Jan 4, 2024
@cfryanr cfryanr enabled auto-merge January 4, 2024 20:32
Copy link
Member

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm per review over zoom.

@cfryanr cfryanr merged commit bdb7f80 into main Jan 4, 2024
39 checks passed
@cfryanr cfryanr deleted the kube_v0.29.0 branch January 4, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants