Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #1808

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Bump dependencies #1808

merged 1 commit into from
Dec 8, 2023

Conversation

pinniped-ci-bot
Copy link
Member

Automatically bumped all go.mod direct dependencies and/or images in dockerfiles.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cdd38dd) 79.12% compared to head (d8ec87d) 79.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1808   +/-   ##
=======================================
  Coverage   79.12%   79.12%           
=======================================
  Files         173      173           
  Lines       16176    16176           
=======================================
  Hits        12800    12800           
  Misses       3056     3056           
  Partials      320      320           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -3,7 +3,7 @@
# Copyright 2020-2023 the Pinniped contributors. All Rights Reserved.
# SPDX-License-Identifier: Apache-2.0

ARG BUILD_IMAGE=golang:1.21.4@sha256:9baee0edab4139ae9b108fffabb8e2e98a67f0b259fd25283c2a084bd74fea0d
Copy link
Member

@cfryanr cfryanr Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is actually a new 1.21.5 release, but the automation is accidentally getting tag latest with an old sha. So we want this bump, but we don't want to call it latest and we want this correct sha:

❯ docker run --rm gcr.io/go-containerregistry/crane digest golang:1.21.5 --platform all
sha256:58e14a93348a3515c2becc54ebd35302128225169d166b7c6802451ab336c907

I'll disable the latest version in the Concourse resource and rerun this CI job, and it should work.

Copy link
Member

@cfryanr cfryanr Dec 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a bug in the Concourse registry-image resource. According to the docs it should only be returning semver version tags, not latest. As a workaround, I've manually disabled the latest tag version in the Concourse UI for that resource.

Copy link
Member

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cfryanr cfryanr merged commit 3b10cc3 into main Dec 8, 2023
39 checks passed
@cfryanr cfryanr deleted the pinny/bump-deps branch December 8, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants