Upgrade fosite to the latest commit on their main branch #1804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Asked if they could do a new release of fosite here: https://github.com/orgs/ory/discussions/83 |
A small part of the session storage changed type in the latest version of fosite compared to the old version of fosite that we were using. Just to be safe, update our session storage version to invalidate any pre-existing sessions upon upgrade of Pinniped.
cfryanr
force-pushed
the
upgrade_fosite
branch
from
f370d37
to
e1954b1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1804 +/- ##
=======================================
Coverage 79.13% 79.13%
=======================================
Files 172 172
Lines 16163 16163
=======================================
Hits 12790 12790
Misses 3054 3054
Partials 319 319 ☔ View full report in Codecov by Sentry. |
cfryanr
force-pushed
the
upgrade_fosite
branch
from
3bd89c2
to
7a3efb9
Compare
cfryanr
commented
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most recent release of fosite is now one year old. Update to the head of their main branch by using a pseudo version in our
go.mod. If Ory releases a new semver release of fosite in the future, then we can go back to using semver for fosite in ourgo.mod.This PR also adds a new config file called
hack/update-go-mod/overrides.confwhich tells the update-go-mod program to use@masterfor fosite when updating the project'sgo.mod. If/when we want to go back to using the regular releases of fosite, we need only submit a new PR to remove that line fromoverrides.conf.Release note: