Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #1801

Merged
merged 3 commits into from
Dec 4, 2023
Merged

Bump dependencies #1801

merged 3 commits into from
Dec 4, 2023

Conversation

pinniped-ci-bot
Copy link
Member

Automatically bumped all go.mod direct dependencies and/or images in dockerfiles.

@cfryanr
Copy link
Member

cfryanr commented Nov 30, 2023

There seems to be a compile error inside the new version of the minify library.

github.com/tdewolff/minify/v2@v2.20.8/minify/minify.go:29:26: cannot use &aspMinifier (value of type **"github.com/tdewolff/minify/v2/html".Minifier) as "github.com/tdewolff/minify/v2".Minifier value in argument to Default.Add: **"github.com/tdewolff/minify/v2/html".Minifier does not implement "github.com/tdewolff/minify/v2".Minifier (missing method Minify)

@cfryanr
Copy link
Member

cfryanr commented Nov 30, 2023

Created an issue on the minify library: tdewolff/minify#642

@cfryanr cfryanr force-pushed the pinny/bump-deps branch 2 times, most recently from 5f1e2f6 to c4ed541 Compare December 4, 2023 17:07
Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef6369d) 79.14% compared to head (ca5ad85) 79.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1801   +/-   ##
=======================================
  Coverage   79.14%   79.14%           
=======================================
  Files         172      172           
  Lines       16163    16163           
=======================================
  Hits        12792    12792           
  Misses       3052     3052           
  Partials      319      319           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfryanr
Copy link
Member

cfryanr commented Dec 4, 2023

The minify compile issue was resolved and they created a new release. This PR now includes that newer release.

Made the switch wherever possible, but since fosite still uses the old
gopkg.in/square/go-jose.v2 there was one test where we still need to use
it as a direct dependency.
@cfryanr cfryanr merged commit 745852e into main Dec 4, 2023
39 checks passed
@cfryanr cfryanr deleted the pinny/bump-deps branch December 4, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants