Infinite default timeout for WhoAmI API call and add --timeout
CLI flag
#1774
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pinniped whoami
CLI command has always had a hardcoded timeout of 20 seconds for theWhoAmI
API call. However, this has always been a problem. When a user needs to interactively authenticate, and when they take more than 20 seconds to do so, then theWhoAmI
request always fails due to the timeout being exceeded, even though they successfully logged in.To fix this, copy how kubectl timeouts work. Introduce a new
--timeout
flag (name of flag copied from the pre-existingpinniped get kubeconfg
flag) and default it to0
which means no timeout (i.e. infinite timeout).The fake Kube client used in the unit tests ignores the context param that is passed to it, so unfortunately there is no easy way to unit test this timeout.
Release note: