tolerate arm64 in tools deployments and jobs #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1703 +/- ##
=======================================
Coverage 79.16% 79.16%
=======================================
Files 163 163
Lines 15767 15767
=======================================
Hits 12482 12482
Misses 2970 2970
Partials 315 315 |
joshuatcasey
approved these changes
Oct 9, 2023
cfryanr
force-pushed
the
tools_tolerations
branch
from
12461a5
to
4e3bdd8
Compare
cfryanr
force-pushed
the
tools_tolerations
branch
from
4e3bdd8
to
bbf4412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind clusters do not put taints on arm64 nodes. However, GKE (and maybe other) clusters do. Just in case we want to run the integration tests on a GKE arm64 cluster, I suspect that we will need this tolerations on our tools deployments.
Release note:
None, changes testing code only.