-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carvel Package POC for local development #1701
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminapetersen
force-pushed
the
ben/carvel-package/local-registry
branch
from
October 10, 2023 16:59
3c1bf6c
to
453de4d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1701 +/- ##
=======================================
Coverage 78.96% 78.96%
=======================================
Files 166 166
Lines 15933 15933
=======================================
Hits 12582 12582
- Misses 3035 3036 +1
+ Partials 316 315 -1 |
benjaminapetersen
force-pushed
the
ben/carvel-package/local-registry
branch
4 times, most recently
from
October 12, 2023 15:24
47f6298
to
4bbd631
Compare
deploy_carvel/deploy/pinniped-package-rbac-concierge-concierge-rbac.yml
Outdated
Show resolved
Hide resolved
deploy_carvel/deploy/pinniped-package-rbac-concierge-concierge-rbac.yml
Outdated
Show resolved
Hide resolved
...rvel/deploy/pinniped-package-rbac-local-user-authenticator-local-user-authenticator-rbac.yml
Outdated
Show resolved
Hide resolved
deploy_carvel/deploy/pinniped-package-rbac-supervisor-supervisor-rbac.yml
Outdated
Show resolved
Hide resolved
benjaminapetersen
force-pushed
the
ben/carvel-package/local-registry
branch
from
November 6, 2023 20:26
3d5315e
to
b6b0bd4
Compare
joshuatcasey
reviewed
Nov 6, 2023
joshuatcasey
reviewed
Nov 6, 2023
benjaminapetersen
force-pushed
the
ben/carvel-package/local-registry
branch
from
November 7, 2023 15:31
b6b0bd4
to
f456167
Compare
joshuatcasey
approved these changes
Nov 7, 2023
I've added an approval. The |
Curious about |
benjaminapetersen
force-pushed
the
ben/carvel-package/local-registry
branch
from
November 8, 2023 16:58
04e3b93
to
a51df4a
Compare
- update kind config to include local registry - configure kind cluster to talk to local registry - docker build & push pinniped dev code to local registry - deploy dev code of the following via the local registry: - concierge - supervisor - local-user-authenticator - Update values.yaml for supervisor,concierge to schema files - Update values.yaml for local-user-authenticator to schema file - Add ytt openapi-v3 generation to build carvel package script - Add supervisor carvel package files - Add concierge carvel package files - Add local-user-authenticator carvel package files - Add hack script to build openapi-v3 files - add --post-install to hack/prepare-for-integration-tests.sh - cleanup local registry in kind-down.sh - webhook_ca_bundle moved in hack script - adjust were to call post-install script - deploy/{}/values.yml image_pull_dockerconfigjson type change to base64 string - Add PINNIPED_USE_LOCAL_KIND_REGISTRY env var - ensures regular use of hack/prepare-for-integration-tests.sh - PINNIPED_USE_LOCAL_KIND_REGISTRY=1 ./hack/prepare-for-integration-tests.sh --clean --alternate-deploy ./hack/noop.sh --post-install ./hack/build-carvel-packages.sh - ./hack/prepare-for-integration-tests.sh --clean - if PINNIPED_USE_LOCAL_KIND_REGISTRY for kind-down.sh in hack/prepare-for-integration-tests.sh - Split carvel build & deploy scripts, add --pre-install flag - add pre-install flag to hack/prepare-for-integration-tests.sh - split /hack/build-carvel-packages.sh and /hack/deploy-carvel-packages.sh - Remove --alternate-deploy-* flags from hack script - Move scripts to hack/lib/carvel_packages - Split build.sh deploy.sh - Separate template files from install artifacts - Generate all install artifacts in $root/deploy_carvel - remove $root/deploy_carvel from git - Extract ytt values to file in hack/prepare-for-integration-tests.sh - pass registry/repo to carvel build scripts
Co-authored-by: Ryan Richard <richardry@vmware.com>
cfryanr
force-pushed
the
ben/carvel-package/local-registry
branch
from
November 8, 2023 21:10
6b2ea5d
to
88fbaad
Compare
Co-authored-by: Benjamin A. Petersen <ben@benjaminapetersen.me>
This reverts commit 9a63213.
cfryanr
force-pushed
the
ben/carvel-package/local-registry
branch
from
November 8, 2023 21:38
88fbaad
to
d4e2622
Compare
Co-authored-by: Benjamin A. Petersen <ben@benjaminapetersen.me>
Co-authored-by: Benjamin A. Petersen <ben@benjaminapetersen.me>
cfryanr
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Carvel Package POC integrated into local development
Image repository is a local repository, requiring an
/etc/hosts
edit with the following lines:# /etc/hosts 127.0.0.1 kind-registry.local
The images created follow this kind of naming convention: