-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support building of multi-arch linux amd64 and arm64 container images #1699
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1699 +/- ##
=======================================
Coverage 79.16% 79.16%
=======================================
Files 163 163
Lines 15767 15767
=======================================
Hits 12482 12482
+ Misses 2970 2969 -1
- Partials 315 316 +1 |
Do we need to change the |
Hmm. It seems like maybe it doesn't matter? GoogleContainerTools/distroless#346 (comment) This deserves more research. Also, https://github.com/GoogleContainerTools/distroless does not document that there is an image called |
Ok, I think I figured this out.
When building our Dockerfile, the By using |
1f4955c
to
f8f7091
Compare
This PR does not by itself enable building of the Pinniped container image for arm64. It makes a few small changes that will be necessary to support complementary changes in our CI pipelines for building and pushing multi-arch (linux/amd64 and linux/arm64) container images for the Pinniped server image. This is part of the solution for #1386.
To try this locally:
docker buildx create --name mybuilder --bootstrap --use
docker buildx build --platform linux/arm64,linux/amd64 --tag your_dockerhub_username/your-image-name:your-tag --push .
image:
references to use the container image that you pushed in the steps above.Release note: