fix flake seen in pod_shutdown_test.go #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1695 +/- ##
==========================================
- Coverage 79.16% 79.14% -0.02%
==========================================
Files 163 163
Lines 15767 15767
==========================================
- Hits 12482 12479 -3
- Misses 2970 2972 +2
- Partials 315 316 +1 |
cfryanr
force-pushed
the
fix_pod_shutdown_test_flake
branch
from
b32095f
to
eb1ac4f
Compare
|
This passed all CI jobs at 11 am on Tues Sept 26. I'm going to force push to run them all again to see if they pass again. |
cfryanr
force-pushed
the
fix_pod_shutdown_test_flake
branch
from
eb1ac4f
to
71c37a2
Compare
|
Everything passed a second time. I will try running everything for a third time. |
cfryanr
force-pushed
the
fix_pod_shutdown_test_flake
branch
from
71c37a2
to
7ca590f
Compare
|
Everything passed a third time, so maybe this PR is helping. |
cfryanr
force-pushed
the
fix_pod_shutdown_test_flake
branch
from
7ca590f
to
87b7ea1
Compare
joshuatcasey
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix a flake in a recently added test seen once here https://hush-house.pivotal.io/builds/1879066113#L6480ce4a:48:59.
Release note: