Display IDP name when prompting for username and password #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfryanr
reviewed
Sep 22, 2023
cfryanr
reviewed
Sep 22, 2023
joshuatcasey
force-pushed
the
jtc/display-idp-name-when-prompting-for-login-181927293
branch
2 times, most recently
from
936645a
to
1291874
Compare
Codecov Report
@@ Coverage Diff @@
## main #1691 +/- ##
==========================================
- Coverage 79.16% 79.15% -0.01%
==========================================
Files 163 163
Lines 15773 15776 +3
==========================================
+ Hits 12487 12488 +1
- Misses 2970 2972 +2
Partials 316 316
|
cfryanr
reviewed
Sep 29, 2023
cfryanr
reviewed
Sep 29, 2023
joshuatcasey
force-pushed
the
jtc/display-idp-name-when-prompting-for-login-181927293
branch
from
1291874
to
aaedcc8
Compare
cfryanr
force-pushed
the
jtc/display-idp-name-when-prompting-for-login-181927293
branch
from
aaedcc8
to
cb600ad
Compare
|
lgtm as of |
cfryanr
approved these changes
Oct 9, 2023
cfryanr
force-pushed
the
jtc/display-idp-name-when-prompting-for-login-181927293
branch
from
cb600ad
to
91ac7c6
Compare
|
Rebased main and enabled auto merge. |
Co-authored-by: Joshua Casey <joshuatcasey@gmail.com>
Co-authored-by: Joshua Casey <joshuatcasey@gmail.com>
Skip showing the banner when the CLI does not know the IDP name from the CLI args (which are typically encoded in the kubeconfig). Co-authored-by: Joshua Casey <joshuatcasey@gmail.com>
cfryanr
force-pushed
the
jtc/display-idp-name-when-prompting-for-login-181927293
branch
from
91ac7c6
to
0a47aa5
Compare
|
lgtm as of |
cfryanr
deleted the
jtc/display-idp-name-when-prompting-for-login-181927293
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#181927293
Note that this PR only shows the IDP name (if provided to
pinniped login oidcvia--upstream-identity-provider-name), and does not perform any verification that the user's login flags will result in a acceptable configuration.