Update docs to clarify which Supervisor port to expose outside cluster #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuatcasey
approved these changes
Aug 21, 2023
Codecov Report
@@ Coverage Diff @@
## main #1631 +/- ##
==========================================
+ Coverage 75.46% 75.48% +0.01%
==========================================
Files 166 166
Lines 15078 15078
==========================================
+ Hits 11379 11381 +2
+ Misses 3401 3399 -2
Partials 298 298 |
cfryanr
force-pushed
the
which_service_doc
branch
from
e9cb637
to
835b8a5
Compare
joshuatcasey
approved these changes
Aug 22, 2023
|
Thanks to @djpbessems for providing suggestions and feedback for this PR! |
|
Noting quick that we have a few font size issues on the live site that we can fix. Quick screenshots: |
| @@ -9,6 +9,7 @@ code { | |||
| } | |||
| pre code { | |||
| background: none; | |||
| font-size: 100%; | |||
There was a problem hiding this comment.
I'll swing back around and take a look at this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update docs to clarify which Supervisor port to expose outside cluster.
This PR also increases the font size of pre formatted code blocks, which was recently decreased to a small font size (by mistake?) in another PR.
This PR also changes the name of this document in the left-hand sidebar. It was recently changed to "As an OIDC Provider" in another PR. This PR changes it to "Required Configuration" in an attempt to make it more clear that the configuration described in this doc are typically the first things that you would configure after installing the Supervisor and that it is not optional for a Supervisor installation.
See deploy preview here: https://deploy-preview-1631--pinniped.netlify.app/docs/howto/supervisor/configure-supervisor/ (until this PR is merged).
Thanks to @djpbessems for providing suggestions and feedback for this PR!
Release note: