Replace agouti and chromedriver with chromedp across the whole project #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1598 +/- ##
==========================================
- Coverage 75.49% 75.47% -0.02%
==========================================
Files 166 166
Lines 15012 15012
==========================================
- Hits 11333 11331 -2
- Misses 3385 3388 +3
+ Partials 294 293 -1 |
cfryanr
force-pushed
the
chromedp
branch
3 times, most recently
from
34c4dd9
to
907b2f7
Compare
joshuatcasey
approved these changes
Aug 1, 2023
cfryanr
force-pushed
the
chromedp
branch
2 times, most recently
from
376ed88
to
aa7c395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loved agouti but it was archived by its author and it seems like it stopped working when Chrome v115 was released in mid-July 2023. chromedp is newer, seems to be maintained, and has the added bonus that it does not require using chromedriver.
Release note:
None because this PR only changes the integration tests.