Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ldapsearch hack script #1594

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Add ldapsearch hack script #1594

merged 3 commits into from
Dec 6, 2023

Conversation

joshuatcasey
Copy link
Member

@joshuatcasey joshuatcasey commented Jul 27, 2023 •
edited
Loading

@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2198b48) 79.11% compared to head (9883b4e) 79.11%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1594   +/-   ##
=======================================
  Coverage   79.11%   79.11%           
=======================================
  Files         173      173           
  Lines       16176    16176           
=======================================
  Hits        12798    12798           
  Misses       3058     3058           
  Partials      320      320

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuatcasey joshuatcasey force-pushed the jtc/add-ldapsearch-hack-script branch from 4acf41b to 8008d15 Compare July 27, 2023 22:08
@benjaminapetersen
Copy link
Member

First look was interesting! Lets chat more.

@joshuatcasey joshuatcasey force-pushed the jtc/add-ldapsearch-hack-script branch from 8008d15 to 3aacc95 Compare August 3, 2023 21:12
@joshuatcasey
Copy link
Member Author

Suggested updates:

  • Some defensive input checks
  • Ability to construct the filter with a login name (perhaps ./ldapsearch.sh --login-name abc or HACK_LOGIN_NAME=abc.
  • Constructing a group query as well

@cfryanr cfryanr force-pushed the jtc/add-ldapsearch-hack-script branch from c2f04aa to 612dadc Compare December 2, 2023 00:12
@cfryanr cfryanr marked this pull request as ready for review December 2, 2023 00:14
@cfryanr
Copy link
Member

cfryanr commented Dec 2, 2023

Suggested updates:

  • Some defensive input checks
  • Ability to construct the filter with a login name (perhaps ./ldapsearch.sh --login-name abc or HACK_LOGIN_NAME=abc.
  • Constructing a group query as well

Done!

@cfryanr cfryanr force-pushed the jtc/add-ldapsearch-hack-script branch 2 times, most recently from 4529bf9 to a9446dc Compare December 5, 2023 22:24
@benjaminapetersen
Copy link
Member

👀

@cfryanr cfryanr force-pushed the jtc/add-ldapsearch-hack-script branch from a9446dc to 9dad15f Compare December 5, 2023 23:33
@cfryanr cfryanr force-pushed the jtc/add-ldapsearch-hack-script branch from 9dad15f to 348187d Compare December 6, 2023 17:16
benjaminapetersen
benjaminapetersen approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cfryanr cfryanr merged commit a05acad into main Dec 6, 2023
39 checks passed
@cfryanr cfryanr deleted the jtc/add-ldapsearch-hack-script branch December 6, 2023 22:02
This was referenced Jul 24, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfryanr cfryanr cfryanr left review comments

@benjaminapetersen benjaminapetersen benjaminapetersen approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joshuatcasey @benjaminapetersen @cfryanr @vmwclabot