Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube cert agent pod requests 0 cpu to avoid scheduling failures #1590

Merged
merged 1 commit into from
Jul 25, 2023
Merged

kube cert agent pod requests 0 cpu to avoid scheduling failures #1590

merged 1 commit into from
Jul 25, 2023

Conversation

cfryanr
Copy link
Member

@cfryanr cfryanr commented Jul 25, 2023

Addresses #1507.

Release note:

TODO something about the bug fix

@codecov
Copy link

codecov bot commented Jul 25, 2023 •
edited
Loading

Codecov Report

Merging #1590 (743cb2d) into main (01393af) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1590      +/-   ##
==========================================
- Coverage   75.49%   75.48%   -0.01%     
==========================================
  Files         166      166              
  Lines       15011    15012       +1     
==========================================
  Hits        11332    11332              
- Misses       3385     3386       +1     
  Partials      294      294
Files Changed Coverage Δ
internal/controller/kubecertagent/kubecertagent.go 92.70% <100.00%> (+0.01%) ⬆️

... and 2 files with indirect coverage changes

@joshuatcasey joshuatcasey merged commit 6bb4e89 into main Jul 25, 2023
5 checks passed
@joshuatcasey joshuatcasey deleted the kube_cert_agent_cpu_request branch July 25, 2023 20:20
benjaminapetersen
benjaminapetersen reviewed Jul 25, 2023
View reviewed changes
Copy link
Member

@benjaminapetersen benjaminapetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminapetersen benjaminapetersen benjaminapetersen left review comments

@joshuatcasey joshuatcasey joshuatcasey approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cfryanr @benjaminapetersen @joshuatcasey @vmwclabot